Bunch of compiler warnings in WPTools components

  • Hi,

    I just took a look to Jenkins (our CI system)/Delphi XE IDE and found a bunch of compiler warnings (around 230!!!) after installing WPTools. Examples:

    [DCC Warning] WPSpell_Controller.pas(3233): W1058 Implicit string cast with potential data loss from 'string' to 'AnsiString'
    [DCC Warning] WPSpell_Language.pas(129): W1050 WideChar reduced to byte char in set expressions. Consider using 'CharInSet' function in 'SysUtils' unit.
    [DCC Warning] WPSpell_StdForm.pas(288): W1058 Implicit string cast with potential data loss from 'TCaption' to 'AnsiString'
    [DCC Warning] WPSpell_OptForm.pas(162): W1058 Implicit string cast with potential data loss from 'TFileName' to 'AnsiString'
    [DCC Warning] WPSpell_Controller.pas(3229): W1057 Implicit string cast from 'AnsiString' to 'string'
    [DCC Warning] WPSpell_StdForm.pas(180): W1057 Implicit string cast from 'AnsiString' to 'string'
    [DCC Warning] WPSpell_OptForm.pas(124): W1057 Implicit string cast from 'AnsiString' to 'string'
    ...

    Can you fix these warnings please?

    It's very necessary for our release and quality assurance (maybe also for other users). We have to reach the goal of zero warnings in our releases.

    Thanks in advance

    /Steven

  • Zitat von wpsupport

    WPSpell did show some warnings, thats correct. Do you have the latest source?
    It did not make sense to add code to "fix" errors which are none.

    Yes we have the latest version of WPSpell (02.06.2013) and WPTools (27.7.2013 - WPTools 7.03). We get the warnings with these versions.

  • Zitat von wpsupport

    Hi,

    it is possible that there are about 3 warnings in wptools.

    BTW - who is "we"

    Here the full list of compiler warnings.
    Used versions: WPSpell 02.06.2013, WPTools 27.7.2013 - WPTools 7.03, Delphi XE.

    That's much more than 3 warnings.

    [DCC Warning] WPSpell_Language.pas(129): W1050 WideChar reduced to byte char in set expressions. Consider using 'CharInSet' function in 'SysUtils' unit.....

    • Offizieller Beitrag

    I was talking about WPTools in my post, not WPSpell.

    It seems so that the file was nonline which did not has a recent change to avoid the messages.

    BTW - if "we" are more developers, please note that this sees to be just a single license. The use in a project more developers are working on, incl. groupleader or developers of other parts of the app is not licensed.