Beiträge von fedpol

fedpol

Julian, can you please convert following DFM's to text format. They are now in binary format and it makes it impossible to compare different revisions of those files. Thanks.

Demos/SpellCheck/AddictSpell/AdWPTDemoU.dfm
Demos/Tasks/Annotation/Unit1.dfm
Demos/Tasks/Bookmarks/BookTest.dfm
Demos/Tasks/EditFields/EdFieldUnit1.dfm
Demos/Tasks/FillPage/FillPageUnit1.dfm
Demos/Tasks/Localisation/LocalTest.dfm
Demos/Tasks/MailM4/HintFormU.dfm
Demos/Tasks/PrinterSetup/PrinterSetU.dfm
Demos/Tasks/RTFVariables/RTFVar1.dfm
Source/WPInfD2.dfm
Source/WPInfDlg.dfm
Source/WPXMLEditor.dfm

fedpol

The text in following document is incorrectly wrapped. It should not paint partial and/or full characters beyond the right margin line.

Here is a screenshot
http://img340.imageshack.us/my.php?image=bug92bq0.png

Code

<!WPTools_Format V=518/>
<GlobalPageFormat wpcss="landscape:0;paperw:12240;paperh:15840;margr:720;margl:720;margt:720;margb:720;marg_header:720;marg_footer:720;deftabstop:720;marginmirror:0;"/><StandardFont wpcss="CharFont:'Times New Roman';CharFontSize:1100;"/>
<div><txtobj wpsty=[[Type:12;Mode:8;Width:4543;Height:2503;RelX:1771;RelY:526;Wrap:4;Object:11458448;]] ch=1 data="wpvcl-binary" type="TWPOImage">
<!--EQ4KAFRXUE9JbWFnZQBUUEYwCVRXUE9JbWFnZQAHV2lkdGhUVwIPCEhlaWdodFRXAg8MV3JpdGVSVEZNb2RlBwx3b2JBdXRvbWF0aWMGT2JqVGFnAgAAAEpQ
RwD/2P/gABBKRklGAAEBAQAAAAAAAP/bAEMACAYGBwYFCAcHBwkJCAoMFA0MCwsMGRITDxQdGh8eHRocHCAkLicgIiwjHBwoNyksMDE0NDQfJzk9ODI8LjM0
Mv/bAEMBCQkJDAsMGA0NGDIhHCEyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMv/AABEIAAEAAQMBIgACEQEDEQH/
xAAfAAABBQEBAQEBAQAAAAAAAAAAAQIDBAUGBwgJCgv/xAC1EAACAQMDAgQDBQUEBAAAAX0BAgMABBEFEiExQQYTUWEHInEUMoGRoQgjQrHBFVLR8CQzYnKC
CQoWFxgZGiUmJygpKjQ1Njc4OTpDREVGR0hJSlNUVVZXWFlaY2RlZmdoaWpzdHV2d3h5eoOEhYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPE
xcbHyMnK0tPU1dbX2Nna4eLj5OXm5+jp6vHy8/T19vf4+fr/xAAfAQADAQEBAQEBAQEBAAAAAAAAAQIDBAUGBwgJCgv/xAC1EQACAQIEBAMEBwUEBAABAncA
AQIDEQQFITEGEkFRB2FxEyIygQgUQpGhscEJIzNS8BVictEKFiQ04SXxFxgZGiYnKCkqNTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqC
g4SFhoeIiYqSk5SVlpeYmZqio6Slpqeoqaqys7S1tre4ubrCw8TFxsfIycrS09TV1tfY2dri4+Tl5ufo6ery8/T19vf4+fr/2gAMAwEAAhEDEQA/AOLooor5
k/cT/9kA-->
</txtobj>The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog.</div>

Alles anzeigen

fedpol

I use wpobjLockedPos to prevent the user from moving certain images in the document but those image are still moveable.

fedpol

In the function TWPCustomRichText.OnToolBarIconSelection the function OpenDialog is called in several places. It can happen that during OpenDialog an event is raised, in which case the action is stuck in the checked state. For instance, if an exception is raised during a file save, then there will be a check mark in the menu next to the "save" item. If you then select this item, the check will disappear but the action will not be executed. Selecting it a second time will execute the action again.

I think it is better to replace

Code

OpenDialog(xxx);desel := TRUE;Typ := wptNone;

with

Code

desel := TRUE;Typ := wptNone;OpenDialog(xxx);

or

Code

try
    OpenDialog(xxx);
finally
    desel := TRUE;
    Typ := wptNone;
end;

It would also be better to remove the try/except from WPI_CO_Open because if something goes wrong during the opening of a file, WPTools will eat the exception and the user/program will never know.

fedpol

* bump *

fedpol

* bump *

fedpol

Thanks, it works.

fedpol

I have an image that is relative to page. If I complete drag/drop this image outside my page area, it is lost forever, I can no longer select it.

fedpol

I have an image that is relative to page. When I drag/drop this image from the top of page 2 to the bottom of page 1 then the image "disappears".

The second call to ScreenToRTFPage changes RTFPageNr from 0 to 1 and causes the image to be placed at the bottom of page 2 instead of page 1.

Code

procedure TWPCustomRtfEdit.MouseUp(Button: TMouseButton; Shift: TShiftState;
  X, Y: Integer);


...


if ScreenToRTFPage(FFrameVar.fx,
  FFrameVar.fy, RtfX, RtfY, RTFPageNr, TRUE) and SaveChanging then
begin


  if not ScreenToRTFPage(FFrameVar.fx + FFrameVar.fw, // IGNORE X, V5-11.2 moved here with IF
    FFrameVar.fy
{$IFNDEF AllowTallObjects} + FFrameVar.fh{$ENDIF},
    RtfX1, RtfY1, RTFPageNr, TRUE) then
  begin
    RtfX1 := RtfX + MulDiv(FFrameVar.fw, Memo.CurrentXPixelsPerInch, WPScreenPixelsPerInch);
    RtfY1 := RtfY + MulDiv(FFrameVar.fh, Memo.CurrentYPixelsPerInch, WPScreenPixelsPerInch);
  end;


...

Alles anzeigen

fedpol

You can no longer click between the two last chars of a paragraph. It used to work in 5.23.5 and earlier.

In function TParagraph.LinePosFromX

Code

if Result<CharCount then www := CharPos[Result+1].xoff

should be

Code

if (Result + 1) < CharCount then www := CharPos[Result+1].xoff

fedpol

Julian, I reported this bug a long time ago but never received a reply.

- start Wordpad5 demo
- type some text and hit enter
- type some more text
- change font size to 40
- type some more text

Here is a screenshot.

fedpol

1. Load the document with Wordpad5 demo.
2. Click on the image (to select it).
3. Notice the location of the blue pin. (first paragraph)
4. Drag the image a few pixels up.
5. Click on the image (to select it).
6. Notice the new location of the blue pin. (last paragraph)

This is strange because "Mode" is wpobjRelativeToPage (16), not wpobjRelativeToParagraph (8).

Code

<!WPTools_Format V=518/>
<div><txtobj wpsty=[[Type:12;Mode:16;Width:2790;Height:2790;RelX:4546;RelY:4274;Wrap:6]] ch=1 data="wpvcl-binary" type="TWPOImage">
<!--EQ4KAFRXUE9JbWFnZQBUUEYwCVRXUE9JbWFnZQAHV2lkdGhUVwIPCEhlaWdodFRXAg8MV3JpdGVSVEZNb2RlBwx3b2JBdXRvbWF0aWMGT2JqVGFnAgAAAEpQ
RwD/2P/gABBKRklGAAEBAQAAAAAAAP/bAEMACAYGBwYFCAcHBwkJCAoMFA0MCwsMGRITDxQdGh8eHRocHCAkLicgIiwjHBwoNyksMDE0NDQfJzk9ODI8LjM0
Mv/bAEMBCQkJDAsMGA0NGDIhHCEyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMv/AABEIAAEAAQMBIgACEQEDEQH/
xAAfAAABBQEBAQEBAQAAAAAAAAAAAQIDBAUGBwgJCgv/xAC1EAACAQMDAgQDBQUEBAAAAX0BAgMABBEFEiExQQYTUWEHInEUMoGRoQgjQrHBFVLR8CQzYnKC
CQoWFxgZGiUmJygpKjQ1Njc4OTpDREVGR0hJSlNUVVZXWFlaY2RlZmdoaWpzdHV2d3h5eoOEhYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPE
xcbHyMnK0tPU1dbX2Nna4eLj5OXm5+jp6vHy8/T19vf4+fr/xAAfAQADAQEBAQEBAQEBAAAAAAAAAQIDBAUGBwgJCgv/xAC1EQACAQIEBAMEBwUEBAABAncA
AQIDEQQFITEGEkFRB2FxEyIygQgUQpGhscEJIzNS8BVictEKFiQ04SXxFxgZGiYnKCkqNTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqC
g4SFhoeIiYqSk5SVlpeYmZqio6Slpqeoqaqys7S1tre4ubrCw8TFxsfIycrS09TV1tfY2dri4+Tl5ufo6ery8/T19vf4+fr/2gAMAwEAAhEDEQA/AOLooor5
k/cT/9kA-->
</txtobj>test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test </div>
<div>test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test</div>
<div>test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test</div>

Alles anzeigen

fedpol

I have an RTF document created with Word 97 which contains text and an image with wrapping style set to "Top & bottom". When I load this document into WPTools then instead of seeing "text 1 + image + text 2" I see "blank + image + text 1 + text 2". WPTools translated the wrapping to wpobjRelativeToParagraph (mode) and wpwrUseWholeLine (wrap). The problem here is wpwrUseWholeLine which, according to the *cough* help file, blocks the complete line and the space before it. This means that existing RTF documents that use "Top & bottom" image wrapping can not be displayed correctly by WPTools.

I would like to see this implemented (correctly).

fedpol

Why not immediately close the current paragraph and start a new one when "\sect" is encountered? After all, "\sect" means "end of section and pararaph". If you delay the creation of the paragraph, like you do now, you will never be able handle it correctly and this bug will never go away.

fedpol

You fixed the bug. Thanks.

fedpol

I tested it with the original document (not the "hello world" example from my initial post) and your fix does not have any effect. I think your fix expects a "}" after "\sect" which is not always the case.

Here is an example without the "}" after "\sect" and Word 97 displays it ok.

Zitat

{\rtf1\ansi a\par b\par c\sect d\par e\par f\par}

fedpol

Thank you. I will try it immediately.

fedpol

Yes, I already did that. I was hoping that you would also include it in the official version of WPTools. If not then I need to use 2^30 instead of 4096.

fedpol

Thank you.

fedpol

* bump *

Beiträge von fedpol

FEDPOL #93 - DFM in binary format

FEDPOL #92 - text not wrapped correctly

FEDPOL #91 - wpobjLockedPos and images

FEDPOL #90 - OnToolBarIconSelection

FEDPOL #89 - image lost forever

FEDPOL #88 - image "disappears"

FEDPOL #25 - font drawing problem

FEDPOL #89 - image lost forever

FEDPOL #88 - image "disappears"

FEDPOL #87 - two last chars of paragraph

FEDPOL #25 - font drawing problem

FEDPOL #86 - wpwrUseWholeLine (part 2)

FEDPOL #85 - wpwrUseWholeLine (part 1)

FEDPOL #76 - Section break in paragraph

FEDPOL #81 - undo duplicates table

FEDPOL #76 - Section break in paragraph

FEDPOL #76 - Section break in paragraph

FEDPOL #82 - paprHidden not saved/loaded

FEDPOL #83 - RTF document info not read correctly

FEDPOL #76 - Section break in paragraph