How to change the fonttype properly? (use DevExpress Combo)

Hi,

The interface SelectedTextAttr will NOT report any font name if the selected text uses different fonts. In this case it is correct to do not show any font name.

But it will also not report any font name if the fonts are (partly) not defined. Since wptools works with attribute inheritance (similar to HTML/CSS) this can happen frequently.

The interface

CurrAttr

implements a workaround to report the default font in case of undefined fonts.

function TWPSetModeControl.GetFontName: TFontName;
begin
  Result := '';
  if Cursor.IsSelected then
    Cursor.SelectedTextAttr.GetFontName(Result)
  else Cursor.WritingTextAttr.GetFontName(Result);
{$IFNDEF DONT_REPORT_DEFAULT_ATTR} // also see DONT_REPORT_DEFAULT_ATTR_STYLE and DONT_REPORT_DEFAULT_ATTR_COLOR
  if (Result = '') and (Cursor.active_paragraph <> nil) and
    (Cursor.active_paragraph.ABaseStyle <> nil) then
    Result := Cursor.active_paragraph.ABaseStyle.AGetFontName;
  if Result = '' then
    FRichText.DefaultAttr.GetFontName(Result);
  if Result = '' then Result := DefaultFontName;
{$ENDIF}
end;

So if you use CurrAttr.FontName it should work for the current and the selected fonts to update the combo.

Julian

Hi,

WPRichText1.CurrAttr.FontName

is a simplified property. It will display a font even if currently there is a) no font defined (using default font) or b) different fonts are active in selection.

In my code I use a more complicated approach which uses the new WPTools 5 Attribute Interfaces (SelTextAttr and WritingTextAttr)

The code is in unit WPCtrRich.PAS:

if IsSelected then
begin
if not SelectedTextAttr.GetFontName(fnt) then
fnt := ' ';
FToolBar.UpdateSelection(wptName, fnt, 0);
end else FToolBar.UpdateSelection(wptName, CurrAttr.FontName, 0);

Here the WPToolBar is updated.

In this code the combo is updated using CurrAttr.FontName if no text is selected, othewise the SeletectedTextAttr.GetFontName function(!) is used. That function returns FALSE if the selection uses different fonts.

You can convert this code to DX as

if WPRichText.IsSelected then
    begin
        if not WPRichText.SelectedTextAttr.GetFontName(fnt) then
           fnt := '  ';
        dxBarFontNameCombo1.Text :=  := fnt;
    end 
    else dxBarFontNameCombo1.Text := WPRichText.CurrAttr.FontName;

Zitat

2. When selecting some text with both defined and undefined fonttypes, the control will show the description of the defined fonttype in the dxBarComboBox.

I don't see a chance to do that - undefined + defined = undefined in the SelectedTextAttr.

Zitat

How to make sure that text in the editor will always be defined, aspecially when typing new text directly into the editor.

When loading RTF text the fonts which equal the default fonts are removed. If you dio not like this handling (it is required for proper paragraph style operation) you can disable this using the compiler define DONT_FIX_DEFSTYLE (used by WPIOReadRTF)

When typing RTF text the property WriteTextAttr is used. Here you can check with GetFontName if one is defined. OnClear is a good event to initialize this interface.

Regards,

Julian Ziersch

>>Can you tell me where I can set: define DONT_FIX_DEFSTYLE ?

IDE Menu, Project Options, Conditionals,
entere there and do a BuildAll

>>And also how to use the property WriteTextAttr with checking GetFontName.

var f : string;
if not WP.WritingTextAttr.GetFontName(f) then
WP.WritingTextAttr.SetFontName('Arial');

>>OnClear is a good event to initialize this interface???

OnClear is a published event of TWPRichText

To change this behavior a change in the cor unit is required. I have implemented this change as default in upcoming release - it will be possible to switch it off.

Julian

You're welcome,

the new release is now online.

Julian

Hi,

I made a mistake when testing the change. Infact it worked - sometimes - but qwhen developing a test app I found out that selected text which used a font always reported a NULL font. I had to reports V5.20.5 - also to the chance to include a change to make it work with C++Builder 2006 Update 2. (I had to wait for German release of the update.)

My demo is using a simple combo box "mbLettertype".

Its uses this code:

procedure TForm1.FormCreate(Sender: TObject);
begin
  mbLettertype.Items := Screen.Fonts;
  WPRichText1Clear(nil);
end;


// Button: Load Text
procedure TForm1.Button1Click(Sender: TObject);
begin
  WPRichText1.Load();
end;


// Button: Clear Text
procedure TForm1.Button2Click(Sender: TObject);
begin
  WPRichText1.Clear();
end;


// Update the "Toolbar"
procedure TForm1.mbLettertypeChange(Sender: TObject);
begin
   // We do not want to assign fonts which do not exist!
   if (mbLettertype.Text='') or
      (mbLettertype.Items.IndexOf(mbLettertype.Text)>=0) then
      WPRichText1.CurrAttr.FontName := mbLettertype.Text;
end;


// Apply change in "Toolbar" to text
procedure TForm1.WPRichText1CharacterAttrChange(Sender: TObject;
  Attribute: TWPSetModeControl);
var fnt : TFontName;
begin
  if WPRichText1.IsSelected then
  begin 
    if not WPRichText1.SelectedTextAttr.GetFontName(fnt) then fnt := '';
    mbLettertype.Text := fnt;
  end else 
    mbLettertype.Text := WPRichText1.CurrAttr.FontName; 
end;


// This is executed after "clear". 
procedure TForm1.WPRichText1Clear(Sender: TObject);
begin
  WPRichText1.DefaultAttr.Clear;
  WPRichText1.DefaultAttr.SetFontName('Courier New');
  WPRichText1.DefaultAttr.SetFontSize(10);
  WPRichText1.WritingAttr.Clear;
end;

Now it appears to work.

Julian